Remove dead code elimination for when iSSG isn't used #9267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 31, 2019
Stats from current PRDefault Server Mode (Increase detected
|
| zeit/next.js canary | ijjk/next.js fix/terser-spr-check | Change | |
|---|---|---|---|
| buildDuration | 14.1s | 16.1s | |
| nodeModulesSize | 48.5 MB | 48.5 MB | -822 B |
Client Bundles (main, webpack, commons) Overall increase ⚠️
| zeit/next.js canary | ijjk/next.js fix/terser-spr-check | Change | |
|---|---|---|---|
| main-HASH.js | 16.6 kB | 16.6 kB | ✓ |
| main-HASH.js gzip | 5.86 kB | 5.86 kB | ✓ |
| webpack-HASH.js | 1.53 kB | 1.53 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| 16b1a7225520..63e75d588.js | 19.7 kB | 20.1 kB | |
| 16b1a7225520..d588.js gzip | 7.23 kB | 7.38 kB | |
| 4952ddcd88e7..bfe360fe6.js | 10.5 kB | 10.5 kB | ✓ |
| 4952ddcd88e7..0fe6.js gzip | 4.06 kB | 4.06 kB | ✓ |
| commons.HASH.js | 11.3 kB | 11.3 kB | ✓ |
| commons.HASH.js gzip | 4.23 kB | 4.23 kB | ✓ |
| de003c3a9d30..9e9c1d310.js | 28.6 kB | 28.6 kB | ✓ |
| de003c3a9d30..d310.js gzip | 10.8 kB | 10.8 kB | ✓ |
| framework.1b..cdcfe1283.js | 125 kB | 125 kB | ✓ |
| framework.1b..1283.js gzip | 39.4 kB | 39.4 kB | ✓ |
| Overall change | 214 kB | 214 kB |
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
| zeit/next.js canary | ijjk/next.js fix/terser-spr-check | Change | |
|---|---|---|---|
| main-HASH.module.js | 14.1 kB | 14 kB | -36 B |
| main-HASH.module.js gzip | 5.28 kB | 5.26 kB | -27 B |
| webpack-HASH.module.js | 1.53 kB | 1.53 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| 16b1a7225520..51.module.js | 15.8 kB | 16.2 kB | |
| 16b1a7225520..dule.js gzip | 6.07 kB | 6.21 kB | |
| 4952ddcd88e7..4a.module.js | 12.8 kB | 12.8 kB | ✓ |
| 4952ddcd88e7..dule.js gzip | 4.75 kB | 4.75 kB | ✓ |
| de003c3a9d30..c0.module.js | 22.1 kB | 22.1 kB | -2 B |
| de003c3a9d30..dule.js gzip | 8.68 kB | 8.67 kB | -11 B |
| framework.5b..d3.module.js | 125 kB | 125 kB | -37 B |
| framework.5b..dule.js gzip | 39.4 kB | 39.4 kB | -8 B |
| Overall change | 192 kB | 192 kB |
Client Pages
| zeit/next.js canary | ijjk/next.js fix/terser-spr-check | Change | |
|---|---|---|---|
| _app.js | 1.63 kB | 1.63 kB | ✓ |
| _app.js gzip | 788 B | 788 B | ✓ |
| _error.js | 12.3 kB | 12.3 kB | ✓ |
| _error.js gzip | 4.79 kB | 4.79 kB | ✓ |
| hooks.js | 1.92 kB | 1.92 kB | ✓ |
| hooks.js gzip | 941 B | 941 B | ✓ |
| index.js | 318 B | 318 B | ✓ |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js | 5.81 kB | 5.81 kB | ✓ |
| link.js gzip | 2.56 kB | 2.56 kB | ✓ |
| routerDirect.js | 413 B | 413 B | ✓ |
| routerDirect.js gzip | 285 B | 285 B | ✓ |
| withRouter.js | 423 B | 423 B | ✓ |
| withRouter.js gzip | 284 B | 284 B | ✓ |
| Overall change | 22.8 kB | 22.8 kB | ✓ |
Client Pages Modern Overall decrease ✓
| zeit/next.js canary | ijjk/next.js fix/terser-spr-check | Change | |
|---|---|---|---|
| _app.module.js | 1.54 kB | 1.53 kB | -9 B |
| _app.module.js gzip | 759 B | 749 B | -10 B |
| _error.module.js | 10.5 kB | 10.5 kB | ✓ |
| _error.module.js gzip | 4.26 kB | 4.26 kB | ✓ |
| hooks.module.js | 1.52 kB | 1.52 kB | ✓ |
| hooks.module.js gzip | 792 B | 792 B | ✓ |
| index.module.js | 292 B | 292 B | ✓ |
| index.module.js gzip | 223 B | 223 B | ✓ |
| link.module.js | 5.49 kB | 5.47 kB | -23 B |
| link.module.js gzip | 2.47 kB | 2.46 kB | -9 B |
| routerDirect.module.js | 399 B | 399 B | ✓ |
| routerDirect..dule.js gzip | 285 B | 285 B | ✓ |
| withRouter.module.js | 409 B | 409 B | ✓ |
| withRouter.m..dule.js gzip | 282 B | 282 B | ✓ |
| Overall change | 20.2 kB | 20.1 kB | -32 B |
Client Build Manifests
| zeit/next.js canary | ijjk/next.js fix/terser-spr-check | Change | |
|---|---|---|---|
| _buildManifest.js | 244 B | 244 B | ✓ |
| _buildManifest.js gzip | 199 B | 199 B | ✓ |
| _buildManifest.module.js | 251 B | 251 B | ✓ |
| _buildManife..dule.js gzip | 210 B | 210 B | ✓ |
| Overall change | 495 B | 495 B | ✓ |
Rendered Page Sizes
| zeit/next.js canary | ijjk/next.js fix/terser-spr-check | Change | |
|---|---|---|---|
| index.html | 3.94 kB | 3.94 kB | ✓ |
| index.html gzip | 1 kB | 1 kB | ✓ |
| link.html | 4.47 kB | 4.47 kB | ✓ |
| link.html gzip | 1.08 kB | 1.08 kB | ✓ |
| withRouter.html | 4.47 kB | 4.47 kB | ✓ |
| withRouter.html gzip | 1.07 kB | 1.07 kB | ✓ |
| Overall change | 12.9 kB | 12.9 kB | ✓ |
Serverless Mode (Increase detected ⚠️ )
General Overall decrease ✓
| zeit/next.js canary | ijjk/next.js fix/terser-spr-check | Change | |
|---|---|---|---|
| buildDuration | 14.5s | 16.3s | |
| nodeModulesSize | 48.5 MB | 48.5 MB | -822 B |
Client Bundles (main, webpack, commons) Overall increase ⚠️
| zeit/next.js canary | ijjk/next.js fix/terser-spr-check | Change | |
|---|---|---|---|
| main-HASH.js | 16.6 kB | 16.6 kB | ✓ |
| main-HASH.js gzip | 5.86 kB | 5.86 kB | ✓ |
| webpack-HASH.js | 1.53 kB | 1.53 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| 16b1a7225520..63e75d588.js | 19.7 kB | 20.1 kB | |
| 16b1a7225520..d588.js gzip | 7.23 kB | 7.38 kB | |
| 4952ddcd88e7..bfe360fe6.js | 10.5 kB | 10.5 kB | ✓ |
| 4952ddcd88e7..0fe6.js gzip | 4.06 kB | 4.06 kB | ✓ |
| commons.HASH.js | 11.3 kB | 11.3 kB | ✓ |
| commons.HASH.js gzip | 4.23 kB | 4.23 kB | ✓ |
| de003c3a9d30..9e9c1d310.js | 28.6 kB | 28.6 kB | ✓ |
| de003c3a9d30..d310.js gzip | 10.8 kB | 10.8 kB | ✓ |
| framework.1b..cdcfe1283.js | 125 kB | 125 kB | ✓ |
| framework.1b..1283.js gzip | 39.4 kB | 39.4 kB | ✓ |
| Overall change | 214 kB | 214 kB |
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
| zeit/next.js canary | ijjk/next.js fix/terser-spr-check | Change | |
|---|---|---|---|
| main-HASH.module.js | 14.1 kB | 14 kB | -36 B |
| main-HASH.module.js gzip | 5.28 kB | 5.26 kB | -27 B |
| webpack-HASH.module.js | 1.53 kB | 1.53 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| 16b1a7225520..51.module.js | 15.8 kB | 16.2 kB | |
| 16b1a7225520..dule.js gzip | 6.07 kB | 6.21 kB | |
| 4952ddcd88e7..4a.module.js | 12.8 kB | 12.8 kB | ✓ |
| 4952ddcd88e7..dule.js gzip | 4.75 kB | 4.75 kB | ✓ |
| de003c3a9d30..c0.module.js | 22.1 kB | 22.1 kB | -2 B |
| de003c3a9d30..dule.js gzip | 8.68 kB | 8.67 kB | -11 B |
| framework.5b..d3.module.js | 125 kB | 125 kB | -37 B |
| framework.5b..dule.js gzip | 39.4 kB | 39.4 kB | -8 B |
| Overall change | 192 kB | 192 kB |
Client Pages
| zeit/next.js canary | ijjk/next.js fix/terser-spr-check | Change | |
|---|---|---|---|
| _app.js | 1.63 kB | 1.63 kB | ✓ |
| _app.js gzip | 788 B | 788 B | ✓ |
| _error.js | 12.3 kB | 12.3 kB | ✓ |
| _error.js gzip | 4.79 kB | 4.79 kB | ✓ |
| hooks.js | 1.92 kB | 1.92 kB | ✓ |
| hooks.js gzip | 941 B | 941 B | ✓ |
| index.js | 318 B | 318 B | ✓ |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js | 5.81 kB | 5.81 kB | ✓ |
| link.js gzip | 2.56 kB | 2.56 kB | ✓ |
| routerDirect.js | 413 B | 413 B | ✓ |
| routerDirect.js gzip | 285 B | 285 B | ✓ |
| withRouter.js | 423 B | 423 B | ✓ |
| withRouter.js gzip | 284 B | 284 B | ✓ |
| Overall change | 22.8 kB | 22.8 kB | ✓ |
Client Pages Modern Overall decrease ✓
| zeit/next.js canary | ijjk/next.js fix/terser-spr-check | Change | |
|---|---|---|---|
| _app.module.js | 1.54 kB | 1.53 kB | -9 B |
| _app.module.js gzip | 759 B | 749 B | -10 B |
| _error.module.js | 10.5 kB | 10.5 kB | ✓ |
| _error.module.js gzip | 4.26 kB | 4.26 kB | ✓ |
| hooks.module.js | 1.52 kB | 1.52 kB | ✓ |
| hooks.module.js gzip | 792 B | 792 B | ✓ |
| index.module.js | 292 B | 292 B | ✓ |
| index.module.js gzip | 223 B | 223 B | ✓ |
| link.module.js | 5.49 kB | 5.47 kB | -23 B |
| link.module.js gzip | 2.47 kB | 2.46 kB | -9 B |
| routerDirect.module.js | 399 B | 399 B | ✓ |
| routerDirect..dule.js gzip | 285 B | 285 B | ✓ |
| withRouter.module.js | 409 B | 409 B | ✓ |
| withRouter.m..dule.js gzip | 282 B | 282 B | ✓ |
| Overall change | 20.2 kB | 20.1 kB | -32 B |
Client Build Manifests
| zeit/next.js canary | ijjk/next.js fix/terser-spr-check | Change | |
|---|---|---|---|
| _buildManifest.js | 244 B | 244 B | ✓ |
| _buildManifest.js gzip | 199 B | 199 B | ✓ |
| _buildManifest.module.js | 251 B | 251 B | ✓ |
| _buildManife..dule.js gzip | 210 B | 210 B | ✓ |
| Overall change | 495 B | 495 B | ✓ |
Serverless bundles
| zeit/next.js canary | ijjk/next.js fix/terser-spr-check | Change | |
|---|---|---|---|
| _error.js | 241 kB | 241 kB | ✓ |
| _error.js gzip | 64.4 kB | 64.4 kB | ✓ |
| hooks.html | 4.08 kB | 4.08 kB | ✓ |
| hooks.html gzip | 1.03 kB | 1.03 kB | ✓ |
| index.js | 241 kB | 241 kB | ✓ |
| index.js gzip | 64.5 kB | 64.5 kB | ✓ |
| link.js | 274 kB | 274 kB | ✓ |
| link.js gzip | 73.5 kB | 73.5 kB | ✓ |
| routerDirect.js | 267 kB | 267 kB | ✓ |
| routerDirect.js gzip | 71.5 kB | 71.5 kB | ✓ |
| withRouter.js | 267 kB | 267 kB | ✓ |
| withRouter.js gzip | 71.6 kB | 71.6 kB | ✓ |
| Overall change | 1.29 MB | 1.29 MB | ✓ |
Commit: 666ed62
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall decrease ✓
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
Client Pages
Client Pages Modern Overall decrease ✓
Client Build Manifests
Rendered Page Sizes
Serverless Mode (Decrease detected ✓)General Overall decrease ✓
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
Client Pages
Client Pages Modern Overall decrease ✓
Client Build Manifests
Serverless bundles
Commit: b0d868b |
Timer
reviewed
Oct 31, 2019
ijjk
changed the title
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall decrease ✓
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
DiffsDiff for _buildManifest.js@@ -1 +1 @@
-self.__BUILD_MANIFEST = (function(a){return {"/link":[a],"/routerDirect":[a],"/withRouter":[a]}}("static\u002Fchunks\u002F16b1a72255206b7853bf6603dc58ec83de39b142.b45ed1163cffb8de5382.js"));self.__BUILD_MANIFEST_CB && self.__BUILD_MANIFEST_CB()
\ No newline at end of file
+self.__BUILD_MANIFEST = (function(a){return {"/link":[a],"/routerDirect":[a],"/withRouter":[a]}}("static\u002Fchunks\u002F16b1a72255206b7853bf6603dc58ec83de39b142.a9e45275d81f65ce1b3a.js"));self.__BUILD_MANIFEST_CB && self.__BUILD_MANIFEST_CB()
\ No newline at end of fileDiff for _buildManifest.module.js@@ -1 +1 @@
-self.__BUILD_MANIFEST = (function(a){return {"/link":[a],"/routerDirect":[a],"/withRouter":[a]}}("static\u002Fchunks\u002F16b1a72255206b7853bf6603dc58ec83de39b142.6676b8996c653de03131.module.js"));self.__BUILD_MANIFEST_CB && self.__BUILD_MANIFEST_CB()
\ No newline at end of file
+self.__BUILD_MANIFEST = (function(a){return {"/link":[a],"/routerDirect":[a],"/withRouter":[a]}}("static\u002Fchunks\u002F16b1a72255206b7853bf6603dc58ec83de39b142.13a61a2410d3fe9a0cb1.module.js"));self.__BUILD_MANIFEST_CB && self.__BUILD_MANIFEST_CB()
\ No newline at end of fileDiff for link.html@@ -18,7 +18,7 @@
as="script" crossorigin="anonymous" />
<link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.710f68a91537b45d6153.module.js"
as="script" crossorigin="anonymous" />
- <link rel="preload" href="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.6676b8996c653de03131.module.js"
+ <link rel="preload" href="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.13a61a2410d3fe9a0cb1.module.js"
as="script" crossorigin="anonymous" />
<link rel="preload" href="/_next/static/runtime/main-f59e55f2f069a03aa793.module.js"
as="script" crossorigin="anonymous" />
@@ -62,9 +62,9 @@
async="" crossorigin="anonymous" nomodule=""></script>
<script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.710f68a91537b45d6153.module.js"
async="" crossorigin="anonymous" type="module"></script>
- <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.b45ed1163cffb8de5382.js"
+ <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.a9e45275d81f65ce1b3a.js"
async="" crossorigin="anonymous" nomodule=""></script>
- <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.6676b8996c653de03131.module.js"
+ <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.13a61a2410d3fe9a0cb1.module.js"
async="" crossorigin="anonymous" type="module"></script>
<script src="/_next/static/runtime/main-30f56449cfbe7044b21b.js"
async="" crossorigin="anonymous" nomodule=""></script>Diff for withRouter.html@@ -18,7 +18,7 @@
as="script" crossorigin="anonymous" />
<link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.710f68a91537b45d6153.module.js"
as="script" crossorigin="anonymous" />
- <link rel="preload" href="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.6676b8996c653de03131.module.js"
+ <link rel="preload" href="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.13a61a2410d3fe9a0cb1.module.js"
as="script" crossorigin="anonymous" />
<link rel="preload" href="/_next/static/runtime/main-f59e55f2f069a03aa793.module.js"
as="script" crossorigin="anonymous" />
@@ -60,9 +60,9 @@
async="" crossorigin="anonymous" nomodule=""></script>
<script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.710f68a91537b45d6153.module.js"
async="" crossorigin="anonymous" type="module"></script>
- <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.b45ed1163cffb8de5382.js"
+ <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.a9e45275d81f65ce1b3a.js"
async="" crossorigin="anonymous" nomodule=""></script>
- <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.6676b8996c653de03131.module.js"
+ <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.13a61a2410d3fe9a0cb1.module.js"
async="" crossorigin="anonymous" type="module"></script>
<script src="/_next/static/runtime/main-30f56449cfbe7044b21b.js"
async="" crossorigin="anonymous" nomodule=""></script>Serverless Mode (Decrease detected ✓)General Overall decrease ✓
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles Overall decrease ✓
Commit: 03b31cc |
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall decrease ✓
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
DiffsDiff for _buildManifest.js@@ -1 +1 @@
-self.__BUILD_MANIFEST = (function(a){return {"/link":[a],"/routerDirect":[a],"/withRouter":[a]}}("static\u002Fchunks\u002F16b1a72255206b7853bf6603dc58ec83de39b142.b45ed1163cffb8de5382.js"));self.__BUILD_MANIFEST_CB && self.__BUILD_MANIFEST_CB()
\ No newline at end of file
+self.__BUILD_MANIFEST = (function(a){return {"/link":[a],"/routerDirect":[a],"/withRouter":[a]}}("static\u002Fchunks\u002F16b1a72255206b7853bf6603dc58ec83de39b142.a9e45275d81f65ce1b3a.js"));self.__BUILD_MANIFEST_CB && self.__BUILD_MANIFEST_CB()
\ No newline at end of fileDiff for _buildManifest.module.js@@ -1 +1 @@
-self.__BUILD_MANIFEST = (function(a){return {"/link":[a],"/routerDirect":[a],"/withRouter":[a]}}("static\u002Fchunks\u002F16b1a72255206b7853bf6603dc58ec83de39b142.6676b8996c653de03131.module.js"));self.__BUILD_MANIFEST_CB && self.__BUILD_MANIFEST_CB()
\ No newline at end of file
+self.__BUILD_MANIFEST = (function(a){return {"/link":[a],"/routerDirect":[a],"/withRouter":[a]}}("static\u002Fchunks\u002F16b1a72255206b7853bf6603dc58ec83de39b142.13a61a2410d3fe9a0cb1.module.js"));self.__BUILD_MANIFEST_CB && self.__BUILD_MANIFEST_CB()
\ No newline at end of fileDiff for link.html@@ -18,7 +18,7 @@
as="script" crossorigin="anonymous" />
<link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.710f68a91537b45d6153.module.js"
as="script" crossorigin="anonymous" />
- <link rel="preload" href="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.6676b8996c653de03131.module.js"
+ <link rel="preload" href="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.13a61a2410d3fe9a0cb1.module.js"
as="script" crossorigin="anonymous" />
<link rel="preload" href="/_next/static/runtime/main-f59e55f2f069a03aa793.module.js"
as="script" crossorigin="anonymous" />
@@ -62,9 +62,9 @@
async="" crossorigin="anonymous" nomodule=""></script>
<script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.710f68a91537b45d6153.module.js"
async="" crossorigin="anonymous" type="module"></script>
- <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.b45ed1163cffb8de5382.js"
+ <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.a9e45275d81f65ce1b3a.js"
async="" crossorigin="anonymous" nomodule=""></script>
- <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.6676b8996c653de03131.module.js"
+ <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.13a61a2410d3fe9a0cb1.module.js"
async="" crossorigin="anonymous" type="module"></script>
<script src="/_next/static/runtime/main-30f56449cfbe7044b21b.js"
async="" crossorigin="anonymous" nomodule=""></script>Diff for withRouter.html@@ -18,7 +18,7 @@
as="script" crossorigin="anonymous" />
<link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.710f68a91537b45d6153.module.js"
as="script" crossorigin="anonymous" />
- <link rel="preload" href="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.6676b8996c653de03131.module.js"
+ <link rel="preload" href="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.13a61a2410d3fe9a0cb1.module.js"
as="script" crossorigin="anonymous" />
<link rel="preload" href="/_next/static/runtime/main-f59e55f2f069a03aa793.module.js"
as="script" crossorigin="anonymous" />
@@ -60,9 +60,9 @@
async="" crossorigin="anonymous" nomodule=""></script>
<script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.710f68a91537b45d6153.module.js"
async="" crossorigin="anonymous" type="module"></script>
- <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.b45ed1163cffb8de5382.js"
+ <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.a9e45275d81f65ce1b3a.js"
async="" crossorigin="anonymous" nomodule=""></script>
- <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.6676b8996c653de03131.module.js"
+ <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.13a61a2410d3fe9a0cb1.module.js"
async="" crossorigin="anonymous" type="module"></script>
<script src="/_next/static/runtime/main-30f56449cfbe7044b21b.js"
async="" crossorigin="anonymous" nomodule=""></script>Serverless Mode (Decrease detected ✓)General Overall decrease ✓
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles Overall decrease ✓
Commit: 5e27a30 |
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall decrease ✓
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
DiffsDiff for _buildManifest.js@@ -1 +1 @@
-self.__BUILD_MANIFEST = (function(a){return {"/link":[a],"/routerDirect":[a],"/withRouter":[a]}}("static\u002Fchunks\u002F16b1a72255206b7853bf6603dc58ec83de39b142.b45ed1163cffb8de5382.js"));self.__BUILD_MANIFEST_CB && self.__BUILD_MANIFEST_CB()
\ No newline at end of file
+self.__BUILD_MANIFEST = (function(a){return {"/link":[a],"/routerDirect":[a],"/withRouter":[a]}}("static\u002Fchunks\u002F16b1a72255206b7853bf6603dc58ec83de39b142.a9e45275d81f65ce1b3a.js"));self.__BUILD_MANIFEST_CB && self.__BUILD_MANIFEST_CB()
\ No newline at end of fileDiff for _buildManifest.module.js@@ -1 +1 @@
-self.__BUILD_MANIFEST = (function(a){return {"/link":[a],"/routerDirect":[a],"/withRouter":[a]}}("static\u002Fchunks\u002F16b1a72255206b7853bf6603dc58ec83de39b142.6676b8996c653de03131.module.js"));self.__BUILD_MANIFEST_CB && self.__BUILD_MANIFEST_CB()
\ No newline at end of file
+self.__BUILD_MANIFEST = (function(a){return {"/link":[a],"/routerDirect":[a],"/withRouter":[a]}}("static\u002Fchunks\u002F16b1a72255206b7853bf6603dc58ec83de39b142.13a61a2410d3fe9a0cb1.module.js"));self.__BUILD_MANIFEST_CB && self.__BUILD_MANIFEST_CB()
\ No newline at end of fileDiff for link.html@@ -18,7 +18,7 @@
as="script" crossorigin="anonymous" />
<link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.710f68a91537b45d6153.module.js"
as="script" crossorigin="anonymous" />
- <link rel="preload" href="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.6676b8996c653de03131.module.js"
+ <link rel="preload" href="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.13a61a2410d3fe9a0cb1.module.js"
as="script" crossorigin="anonymous" />
<link rel="preload" href="/_next/static/runtime/main-f59e55f2f069a03aa793.module.js"
as="script" crossorigin="anonymous" />
@@ -62,9 +62,9 @@
async="" crossorigin="anonymous" nomodule=""></script>
<script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.710f68a91537b45d6153.module.js"
async="" crossorigin="anonymous" type="module"></script>
- <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.b45ed1163cffb8de5382.js"
+ <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.a9e45275d81f65ce1b3a.js"
async="" crossorigin="anonymous" nomodule=""></script>
- <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.6676b8996c653de03131.module.js"
+ <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.13a61a2410d3fe9a0cb1.module.js"
async="" crossorigin="anonymous" type="module"></script>
<script src="/_next/static/runtime/main-30f56449cfbe7044b21b.js"
async="" crossorigin="anonymous" nomodule=""></script>Diff for withRouter.html@@ -18,7 +18,7 @@
as="script" crossorigin="anonymous" />
<link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.710f68a91537b45d6153.module.js"
as="script" crossorigin="anonymous" />
- <link rel="preload" href="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.6676b8996c653de03131.module.js"
+ <link rel="preload" href="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.13a61a2410d3fe9a0cb1.module.js"
as="script" crossorigin="anonymous" />
<link rel="preload" href="/_next/static/runtime/main-f59e55f2f069a03aa793.module.js"
as="script" crossorigin="anonymous" />
@@ -60,9 +60,9 @@
async="" crossorigin="anonymous" nomodule=""></script>
<script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.710f68a91537b45d6153.module.js"
async="" crossorigin="anonymous" type="module"></script>
- <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.b45ed1163cffb8de5382.js"
+ <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.a9e45275d81f65ce1b3a.js"
async="" crossorigin="anonymous" nomodule=""></script>
- <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.6676b8996c653de03131.module.js"
+ <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.13a61a2410d3fe9a0cb1.module.js"
async="" crossorigin="anonymous" type="module"></script>
<script src="/_next/static/runtime/main-30f56449cfbe7044b21b.js"
async="" crossorigin="anonymous" nomodule=""></script>Serverless Mode (Decrease detected ✓)General Overall decrease ✓
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles Overall decrease ✓
Commit: 38eb288 |
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall decrease ✓
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
DiffsDiff for _buildManifest.js@@ -1 +1 @@
-self.__BUILD_MANIFEST = (function(a){return {"/link":[a],"/routerDirect":[a],"/withRouter":[a]}}("static\u002Fchunks\u002F16b1a72255206b7853bf6603dc58ec83de39b142.b45ed1163cffb8de5382.js"));self.__BUILD_MANIFEST_CB && self.__BUILD_MANIFEST_CB()
\ No newline at end of file
+self.__BUILD_MANIFEST = (function(a){return {"/link":[a],"/routerDirect":[a],"/withRouter":[a]}}("static\u002Fchunks\u002F16b1a72255206b7853bf6603dc58ec83de39b142.a9e45275d81f65ce1b3a.js"));self.__BUILD_MANIFEST_CB && self.__BUILD_MANIFEST_CB()
\ No newline at end of fileDiff for _buildManifest.module.js@@ -1 +1 @@
-self.__BUILD_MANIFEST = (function(a){return {"/link":[a],"/routerDirect":[a],"/withRouter":[a]}}("static\u002Fchunks\u002F16b1a72255206b7853bf6603dc58ec83de39b142.6676b8996c653de03131.module.js"));self.__BUILD_MANIFEST_CB && self.__BUILD_MANIFEST_CB()
\ No newline at end of file
+self.__BUILD_MANIFEST = (function(a){return {"/link":[a],"/routerDirect":[a],"/withRouter":[a]}}("static\u002Fchunks\u002F16b1a72255206b7853bf6603dc58ec83de39b142.13a61a2410d3fe9a0cb1.module.js"));self.__BUILD_MANIFEST_CB && self.__BUILD_MANIFEST_CB()
\ No newline at end of fileDiff for link.html@@ -18,7 +18,7 @@
as="script" crossorigin="anonymous" />
<link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.710f68a91537b45d6153.module.js"
as="script" crossorigin="anonymous" />
- <link rel="preload" href="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.6676b8996c653de03131.module.js"
+ <link rel="preload" href="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.13a61a2410d3fe9a0cb1.module.js"
as="script" crossorigin="anonymous" />
<link rel="preload" href="/_next/static/runtime/main-f59e55f2f069a03aa793.module.js"
as="script" crossorigin="anonymous" />
@@ -62,9 +62,9 @@
async="" crossorigin="anonymous" nomodule=""></script>
<script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.710f68a91537b45d6153.module.js"
async="" crossorigin="anonymous" type="module"></script>
- <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.b45ed1163cffb8de5382.js"
+ <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.a9e45275d81f65ce1b3a.js"
async="" crossorigin="anonymous" nomodule=""></script>
- <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.6676b8996c653de03131.module.js"
+ <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.13a61a2410d3fe9a0cb1.module.js"
async="" crossorigin="anonymous" type="module"></script>
<script src="/_next/static/runtime/main-30f56449cfbe7044b21b.js"
async="" crossorigin="anonymous" nomodule=""></script>Diff for withRouter.html@@ -18,7 +18,7 @@
as="script" crossorigin="anonymous" />
<link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.710f68a91537b45d6153.module.js"
as="script" crossorigin="anonymous" />
- <link rel="preload" href="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.6676b8996c653de03131.module.js"
+ <link rel="preload" href="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.13a61a2410d3fe9a0cb1.module.js"
as="script" crossorigin="anonymous" />
<link rel="preload" href="/_next/static/runtime/main-f59e55f2f069a03aa793.module.js"
as="script" crossorigin="anonymous" />
@@ -60,9 +60,9 @@
async="" crossorigin="anonymous" nomodule=""></script>
<script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.710f68a91537b45d6153.module.js"
async="" crossorigin="anonymous" type="module"></script>
- <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.b45ed1163cffb8de5382.js"
+ <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.a9e45275d81f65ce1b3a.js"
async="" crossorigin="anonymous" nomodule=""></script>
- <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.6676b8996c653de03131.module.js"
+ <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.13a61a2410d3fe9a0cb1.module.js"
async="" crossorigin="anonymous" type="module"></script>
<script src="/_next/static/runtime/main-30f56449cfbe7044b21b.js"
async="" crossorigin="anonymous" nomodule=""></script>Serverless Mode (Decrease detected ✓)General Overall decrease ✓
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles Overall decrease ✓
Commit: 0ac212e |
This was referenced Nov 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug can occur where iSSG is used on a page but the data requests aren't run when multiple builds are used and the babel cache is leveraged since we currently rely on the
next-page-configbabel plugin to detect iSSG usage.This adds an additional check to the
TerserPluginto check for the prerender identifier to make sure we don't dead code eliminate the iSSG data fetching code if we are using code from the babel cache and it didn't update that iSSG is being used--
Update: removed dead-code elimination for when iSSG isn't used since we're going to be landing the
fetchpolyfill soonx-ref: #9258
x-ref: #9260